Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Remove contents: read workflow permission #105

Merged
merged 2 commits into from
Aug 31, 2024
Merged

Conversation

chris3ware
Copy link
Member

@chris3ware chris3ware commented Aug 31, 2024

For consistency with other workflows, the permissions scope for GITHUB_TOKEN has been set to {} at the workflow level and the relevant permissions have been added at the job level.

Calling workflows will need to update their permissions accordingly

The permissions removed have been added at the job level.
For code consistency with other workflows
@chris3ware chris3ware requested a review from a team as a code owner August 31, 2024 06:19
@james3ware james3ware merged commit 2b772d3 into main Aug 31, 2024
2 checks passed
@james3ware james3ware deleted the ref-ghtoken-perms branch August 31, 2024 08:45
3ware-release bot pushed a commit that referenced this pull request Aug 31, 2024
## [4.0.0](v3.2.0...v4.0.0) (2024-08-31)

### ⚠ BREAKING CHANGES

* Remove `contents: read` workflow permission (#105)

### Features

* Remove `contents: read` workflow permission ([#105](#105)) ([2b772d3](2b772d3))
@3ware-release
Copy link
Contributor

3ware-release bot commented Aug 31, 2024

This PR is included in version 4.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants