[WIP] Upgrade to Rails 7.0 #3945
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayorova
force-pushed
the
rails70
branch
2 times, most recently
from
11a0b23
to
636ab7e
Compare
mayorova
commented
Nov 21, 2024
| @@ -330,7 +330,7 @@ commands: # reusable commands with parameters | |||
| taskname=$(echo $CIRCLE_JOB | sed -e 's/-\(postgres\|oracle\|[0-9]\).*//') | |||
| bundle exec rake "test:files:${taskname}" | circleci tests run --command="cat > $list" --verbose --split-by=timings | |||
| if [ -s $list ]; then | |||
| bundle exec rake test:run TEST="$(cat $list)" TESTOPTS=--verbose --verbose --trace | |||
| bundle exec rails test $(cat $list | awk 'ORS=" "') --verbose --backtrace | |||
There was a problem hiding this comment.
awk 'ORS=" "' is to merge the list of tests from the file that contain one path per line into a single line separated by spaces.
mayorova
force-pushed
the
rails70
branch
2 times, most recently
from
59ac224
to
86612ed
Compare
jlledom
previously approved these changes
Nov 27, 2024
|
Ready to deploy! |
mayorova
force-pushed
the
rails70
branch
3 times, most recently
from
0ead1d6
to
79ef380
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes
Verification steps
Special notes for your reviewer: