Fix styles for application keys form #3942
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlledom
previously approved these changes
Nov 26, 2024
There was a problem hiding this comment.
It looks much better now.
About the CSS, I have so many questions:
- Is
_tables.scssthe proper place to add the new style? - Is the new style needed? Maybe the new style is not needed because Patternfly itself already includes a class for that.
- Is removing the border actually needed? Apparently tables look like that in PF.
- Is a table the proper element to arrange buttons?
I don't know the answers so I'll approve since it looks good. But maybe we should ask UX people about this.
mayorova
force-pushed
the
fix-styles
branch
2 times, most recently
from
0ec9e70
to
c747568
Compare
|
@jlledom why are you asking so many uncomfortable questions?... It was not me who same up with the idea of using a table row for organizing the buttons... but you can check the latest version, I hope you like it more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Not sure this is the right place to put this... but seems to be working as expected.
Before:
After:
It is especially noticeable when there is an error.
Also:
Before:
After:
Which issue(s) this PR fixes
Verification steps
Special notes for your reviewer: