Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from github3.py to ghapi #181

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Migrate from github3.py to ghapi #181

wants to merge 4 commits into from

Conversation

primetheus
Copy link
Collaborator

@primetheus primetheus commented Aug 22, 2023

This replaces github3.py with ghapi for easier long-term support

fixes #83
fixes #115

githubapp/core.py Dismissed
except GitHubAppValidationError as e:
LOG.error(e)
error_response = make_response(
jsonify(status="ERROR", description=str(e)), 400

Check warning

Code scanning / CodeQL

Information exposure through an exception Medium

Stack trace information
flows to this location and may be exposed to an external user.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in our context this is fine and not an information leak

@primetheus primetheus added the enhancement New feature or request label Aug 22, 2023
@Chocrates
Copy link
Contributor

Is github3.py no longer maintained?

@primetheus
Copy link
Collaborator Author

Is github3.py no longer maintained?

@Chocrates it's still maintained, but features lag behind GitHub's capabilities. Since ghapi is automatically generated from GitHub's API spec, it gives us better compatibility going forward with less to maintain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated Teams API Endpoints Dependency
2 participants