feat: Updates to book based on usage #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielc
previously requested changes
Aug 3, 2023
| run_time: 4 | ||
| image: keramik/runner:dev | ||
| imagePullPolicy: IfNotPresent | ||
| ``` |
There was a problem hiding this comment.
This section should not be deleted. Maybe it can live in a different section be this topic is not covered anywhere else. This section explains how to configure either the Network or Simulation resources to use a local build of the runner.
There was a problem hiding this comment.
Re-added in its own section now with a couple of links to it https://github.com/3box/keramik/pull/51/files#diff-68393f8f40dbae2e7f5a2f43d4cd93a4d9338f305017f5775a327825db9b7e23
3benbox
approved these changes
Aug 7, 2023
| @@ -8,6 +8,7 @@ To analyze the results of a simulation first copy the metrics-TIMESTAMP.parquet | |||
| First restart opentelemetry-0 pod so it writes out the parquet file footer. | |||
|
|
|||
| kubectl delete pod opentelemetry-0 | |||
| sleep 5 # Give pod time to restart | |||
There was a problem hiding this comment.
Just a note, you can use the api the know when the pod is ready
kubectl wait --for=condition=Ready pod/opentelemetry-0
There was a problem hiding this comment.
Thanks, will add that in the next round of book changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.