feat: otel prometheus update #198
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samika98
reviewed
Jul 8, 2024
| @@ -0,0 +1,4 @@ | |||
| global: | |||
| scrape_interval: 10s | |||
| scrape_timeout: 5s | |||
There was a problem hiding this comment.
These seem a bit aggressive to me. Do we need near real-time metrics for our use cases? Can we scrape every 30 seconds to a minute?
There was a problem hiding this comment.
I just pulled these setting along from the existing config.
Want to drop them down to the defaults?
# How frequently to scrape targets by default.
[ scrape_interval: [<duration>](https://prometheus.io/docs/prometheus/latest/configuration/configuration/#duration) | default = 1m ]
# How long until a scrape request times out.
[ scrape_timeout: [<duration>](https://prometheus.io/docs/prometheus/latest/configuration/configuration/#duration) | default = 10s ]
There was a problem hiding this comment.
If we don't have a reason to scrape aggressively then we can save resources by setting defaults
nathanielc
approved these changes
Jul 8, 2024
samika98
reviewed
Jul 8, 2024
samika98
reviewed
Jul 8, 2024
| action: replace | ||
| target_label: kubernetes_container | ||
|
|
||
| processors: |
There was a problem hiding this comment.
Can we filter out duplicates while processing?
There was a problem hiding this comment.
We can if necessary, see this issue about the situation.
samika98
requested changes
Jul 8, 2024
samika98
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prometheus doesn't scrape anything now, it is pushed from opentelemetry.
This should reduce duplicate metrics and provide a single collector to forward to different exporters as required.