chore: use "real" car files for events in scenarios #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lots of breaking cid, multihash, ipld stuff between c1 versions in http/base. for now working around it
don't hard code model to avoid syncing previous data when starting new test. this is a valid test, but different than what we've done so far.
dav1do
force-pushed
the
chore/events_get_use_cid
branch
from
bff2549
to
b5eb153
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the errors running the recon scenario on new versions of ceramic one by creating car files that look like real events so they pass the basic validation. This also puts the actual root CID of the block in c1, so we no longer see the "block not found locally" errors that we were getting in js-ceramic.
I want to clean up the duplicate code and hacks around cid/multihash/ipld versions, and it should be easy once the http client changes land, but for now getting this working is more important.