Optimize save config files

2dust · Dec 7, 2024 · 83ad83b · 83ad83b
1 parent dbd4f55
commit 83ad83b
Show file tree

Hide file tree

Showing 4 changed files with 35 additions and 70 deletions.
diff --git a/v2rayN/ServiceLib/Common/JsonUtils.cs b/v2rayN/ServiceLib/Common/JsonUtils.cs
@@ -70,8 +70,9 @@ public static T DeepCopy<T>(T obj)
         /// </summary>
         /// <param name="obj"></param>
         /// <param name="indented"></param>
+        /// <param name="nullValue"></param>
         /// <returns></returns>
-        public static string Serialize(object? obj, bool indented = true)
+        public static string Serialize(object? obj, bool indented = true, bool nullValue = false)
         {
             var result = string.Empty;
             try
@@ -82,8 +83,8 @@ public static string Serialize(object? obj, bool indented = true)
                 }
                 var options = new JsonSerializerOptions
                 {
-                    WriteIndented = indented ? true : false,
-                    DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull
+                    WriteIndented = indented,
+                    DefaultIgnoreCondition = nullValue ? JsonIgnoreCondition.Never : JsonIgnoreCondition.WhenWritingNull
                 };
                 result = JsonSerializer.Serialize(obj, options);
             }
@@ -100,38 +101,5 @@ public static string Serialize(object? obj, bool indented = true)
         /// <param name="obj"></param>
         /// <returns></returns>
         public static JsonNode? SerializeToNode(object? obj) => JsonSerializer.SerializeToNode(obj);
-
-        /// <summary>
-        /// Save as json file
-        /// </summary>
-        /// <param name="obj"></param>
-        /// <param name="filePath"></param>
-        /// <param name="nullValue"></param>
-        /// <returns></returns>
-        public static int ToFile(object? obj, string? filePath, bool nullValue = true)
-        {
-            if (filePath is null)
-            {
-                return -1;
-            }
-            try
-            {
-                using var file = File.Create(filePath);
-
-                var options = new JsonSerializerOptions
-                {
-                    WriteIndented = true,
-                    DefaultIgnoreCondition = nullValue ? JsonIgnoreCondition.Never : JsonIgnoreCondition.WhenWritingNull
-                };
-
-                JsonSerializer.Serialize(file, obj, options);
-                return 0;
-            }
-            catch (Exception ex)
-            {
-                Logging.SaveLog(ex.Message, ex);
-                return -1;
-            }
-        }
     }
 }
diff --git a/v2rayN/ServiceLib/Handler/ConfigHandler.cs b/v2rayN/ServiceLib/Handler/ConfigHandler.cs
@@ -9,7 +9,6 @@ namespace ServiceLib.Handler
     public class ConfigHandler
     {
         private static readonly string _configRes = Global.ConfigFileName;
-        private static readonly object _objLock = new();
 
         #region ConfigHandler
 
@@ -67,7 +66,6 @@ public class ConfigHandler
             }
 
             config.RoutingBasicItem ??= new();
-
             if (Utils.IsNullOrEmpty(config.RoutingBasicItem.DomainStrategy))
             {
                 config.RoutingBasicItem.DomainStrategy = Global.DomainStrategies.First();//"IPIfNonMatch";
@@ -120,15 +118,6 @@ public class ConfigHandler
             }
 
             config.ConstItem ??= new ConstItem();
-            if (Utils.IsNotEmpty(config.ConstItem.DefIEProxyExceptions))
-            {
-                config.SystemProxyItem.SystemProxyExceptions = $"{config.ConstItem.DefIEProxyExceptions};{config.SystemProxyItem.SystemProxyExceptions}";
-                config.ConstItem.DefIEProxyExceptions = string.Empty;
-            }
-            if (config.SystemProxyItem.SystemProxyExceptions.IsNullOrEmpty())
-            {
-                config.SystemProxyItem.SystemProxyExceptions = Utils.IsWindows() ? Global.SystemProxyExceptionsWindows : Global.SystemProxyExceptionsLinux;
-            }
 
             config.SpeedTestItem ??= new();
             if (config.SpeedTestItem.SpeedTestTimeout < 10)
@@ -167,6 +156,16 @@ public class ConfigHandler
             config.WebDavItem ??= new();
             config.CheckUpdateItem ??= new();
 
+            if (Utils.IsNotEmpty(config.ConstItem.DefIEProxyExceptions))
+            {
+                config.SystemProxyItem.SystemProxyExceptions = $"{config.ConstItem.DefIEProxyExceptions};{config.SystemProxyItem.SystemProxyExceptions}";
+                config.ConstItem.DefIEProxyExceptions = string.Empty;
+            }
+            if (config.SystemProxyItem.SystemProxyExceptions.IsNullOrEmpty())
+            {
+                config.SystemProxyItem.SystemProxyExceptions = Utils.IsWindows() ? Global.SystemProxyExceptionsWindows : Global.SystemProxyExceptionsLinux;
+            }
+
             return config;
         }
 
@@ -177,30 +176,26 @@ public class ConfigHandler
         /// <returns></returns>
         public static async Task<int> SaveConfig(Config config)
         {
-            lock (_objLock)
+            try
             {
-                try
-                {
-                    //save temp file
-                    var resPath = Utils.GetConfigPath(_configRes);
-                    var tempPath = $"{resPath}_temp";
-                    if (JsonUtils.ToFile(config, tempPath) != 0)
-                    {
-                        return -1;
-                    }
+                //save temp file
+                var resPath = Utils.GetConfigPath(_configRes);
+                var tempPath = $"{resPath}_temp";
 
-                    if (File.Exists(resPath))
-                    {
-                        File.Delete(resPath);
-                    }
-                    //rename
-                    File.Move(tempPath, resPath);
-                }
-                catch (Exception ex)
+                var content = JsonUtils.Serialize(config, true, true);
+                if (content.IsNullOrEmpty())
                 {
-                    Logging.SaveLog("ToJsonFile", ex);
                     return -1;
                 }
+                await File.WriteAllTextAsync(tempPath, content);
+
+                //rename
+                File.Move(tempPath, resPath, true);
+            }
+            catch (Exception ex)
+            {
+                Logging.SaveLog("ToJsonFile", ex);
+                return -1;
             }
 
             return 0;

diff --git a/v2rayN/ServiceLib/Services/CoreConfig/CoreConfigSingboxService.cs b/v2rayN/ServiceLib/Services/CoreConfig/CoreConfigSingboxService.cs
@@ -409,7 +409,9 @@ public async Task<RetResult> GenerateClientCustomConfig(ProfileItem node, string
                     {
                         await GenInbounds(singboxConfig);
                         await GenExperimental(singboxConfig);
-                        JsonUtils.ToFile(singboxConfig, fileName, false);
+
+                        var content = JsonUtils.Serialize(singboxConfig, true);
+                        await File.WriteAllTextAsync(fileName, content);
                     }
                 }
                 else

diff --git a/v2rayN/ServiceLib/ViewModels/MainWindowViewModel.cs b/v2rayN/ServiceLib/ViewModels/MainWindowViewModel.cs
@@ -282,16 +282,16 @@ public async Task MyAppExitAsync(bool blWindowsShutDown)
         {
             try
             {
-                Logging.SaveLog("MyAppExit Begin");
-                await SysProxyHandler.UpdateSysProxy(_config, true);
+                Logging.SaveLog("MyAppExitAsync Begin");
 
                 await ConfigHandler.SaveConfig(_config);
+                await SysProxyHandler.UpdateSysProxy(_config, true);
                 await ProfileExHandler.Instance.SaveTo();
                 await StatisticsHandler.Instance.SaveTo();
                 StatisticsHandler.Instance.Close();
                 await CoreHandler.Instance.CoreStop();
 
-                Logging.SaveLog("MyAppExit End");
+                Logging.SaveLog("MyAppExitAsync End");
             }
             catch { }
             finally