list pool: order subnets by priority #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adjust the db model for `Pool` to return the list of subnets sorted by priority, which prohbably is what a user expects in general additionally, fix `assertDictSubset()` to make sure msg is a string, as it would sometimes fail, see 1and1#198
Srudush
reviewed
Feb 8, 2022
|
We should merge this. It makes the output that much more stable. |
test that `ndcli list pool` prints the subets ordered by priority we already have pytests that assume them being ordered by priority by the api, but make sure ndcli prints them like that
miesi
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adjust the db model for
Poolto return the list of subnetssorted by priority, which prohbably is what a user expects in general
additionally, fix the test function
assertDictSubset()to make sure msg is a string,as it would sometimes fail, see #198
resolves #168