add: make log filter async friendly by adding logAsync #3141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the
log
filter logs the passed in values directly. This isn't always helpful when working with async values e.g. in webc components. This change adds thelogAsync
filter to also take promises as any value and awaits them, so you always get some useful output.It could be possible to just eagerly return the value in the sync filter and then use a
.then
call to log the values, but that would leave room for unexpected data mutation, so I didn't implement it that way for now.resolves #3133