This repository has been archived by the owner on May 9, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #157.
Description of the Change
As a WP plugin developer, I'd like to be able to easily set up environments with different (dated) versions of WP to test.
This change allows me to provide WP version in the
10updocker create
inquiry.But still defaults to the
latest
as before.Alternate Designs
As mentioned by @lippoliv in the issue #157, we could add it via CLI parameter.
Also, we may consider adding the validation of the provided version. But I wanted to keep this PR as small as possible.
Benefits
Introduces a feature to install the desired version of WP, without a need to manually downgrade it afterward. Which reduces the traffic, resource consumption, and chance of an error.
Possible Drawbacks
The inquiry may be too long and verbose.
Verification Process
I run
10updocker create
and answeredThen got the new question. Tried default
latest
,5.7.3
,5.7
,foo
.Then checked what versions of WP were actually installed.
I run the
10updocker create
forwordpress.type = dev
type, forwordpress = false
, and forwordpress.version = latest
.Checklist:
Applicable Issues
Changelog Entry
Added WordPress version question to
create
inquiry.