Fix and update "keep original publish date" snippet in the docs #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the docs for the publication date snippet. The argument expected by the core API is `date` and not `post_date`. Also adding `date_gmt` for completion
leogermani
requested review from
peterwilsoncc
and removed request for
a team
leogermani
changed the title
There was a problem hiding this comment.
Good catch but I think it's a little more complicated.
The same filter is used for both internal connections (via wp_insert_post) and external connections (via the REST API).
The forth parameter sent to the filter is the connection, so the code snippet probably needs to be conditional with an is_a() check for whether it's an internal or external push connection.
The pull post snippet looks good.
Update snippet to account for the two types of connections
|
Thanks for the clarification @peterwilsoncc , fixed the snippet |
There was a problem hiding this comment.
Thanks @leogermani
This looks good to me, I've added a bit of a nitpick. I'll commit that and merge the PR.
peterwilsoncc
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the docs for the publication date snippet.
dateand notpost_date. Also addingdate_gmtfor completionDescription of the Change
Fixes one of the snippets in the docs
How to test the Change
Credits
Props @leogermani
Checklist: