Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(monitor): add zkevm batch counters #373

Merged
merged 9 commits into from
Sep 17, 2024
Merged

feat(monitor): add zkevm batch counters #373

merged 9 commits into from
Sep 17, 2024

Conversation

leovct
Copy link
Member

@leovct leovct commented Sep 16, 2024 •
edited
Loading

Description

  • Display the number of trusted, virtual and verified batches if the rpc supports it.
  • Display the gap between virtual and trusted batches.
  • Display the gap between verified and trusted batches.
  • Only display tx pool status if the rpc supports it.

Test

polycli monitor --rpc-url https://rpc.cardona.zkevm-rpc.com
Screenshot 2024-09-17 at 14 14 20 
polycli monitor --rpc-url https://rpc.cardona.zkevm-rpc.com
Screenshot 2024-09-17 at 13 50 41 
polycli monitor # local geth node
Screenshot 2024-09-17 at 13 59 55

Jira / Linear Tickets

x

Testing

x

@leovct
Copy link
Member Author

leovct commented Sep 17, 2024 •
edited
Loading

Batch UI slightly updated after @praetoriansentry's comments:

Screenshot 2024-09-17 at 12 05 46

@leovct leovct changed the title feat(monitor): add trusted, virtual and verified batches counters feat(monitor): add trusted, virtual and verified batch counters Sep 17, 2024
@leovct leovct changed the title feat(monitor): add trusted, virtual and verified batch counters feat(monitor): add zkevm batch counters Sep 17, 2024
praetoriansentry
praetoriansentry approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@praetoriansentry praetoriansentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@praetoriansentry praetoriansentry merged commit 0c533ee into 0xPolygon:main Sep 17, 2024
5 checks passed
@leovct leovct deleted the feat/monitor-zkevm-batches branch September 17, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praetoriansentry praetoriansentry praetoriansentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leovct @praetoriansentry