Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Quiet Mode And Quiet Option #123

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ataumo
Copy link
Contributor

@ataumo ataumo commented Sep 2, 2022

Add Quiet mode to disable all output generated by the script and add QuietOption to set it.

The QuietMode can be
- 1 : for a soft quiet mode (Only warnings and errors)
- 2 (default) : for a complet quiet mode

Examples :

  • Normal command : Invoke-HardeningKitty -Mode Audit -FileFindingList .\lists\finding_list_0x6d69636b_machine.csv
  • With Quiet option (mode 2 by default) : `Invoke-HardeningKitty -Mode Config -FileFindingList .\lists\finding_list_0x6d69636b_machine.csv -Quiet'
  • With soft Quiet option = Invoke-HardeningKitty -Mode Config -FileFindingList .\lists\finding_list_0x6d69636b_machine.csv -SkipMachineInformation -Quiet -QuietOption 1

@0x6d69636b
Copy link
Owner

Thanks for the PR and the input. I have been thinking about fundamentally revising the output and writing of reports/logs and will include a slient mode as a feature. It's already complicated at the moment and with your changes it will be even more complex. However, I would like to simplify output management. Stay tuned :)

@0x6d69636b 0x6d69636b self-assigned this Sep 4, 2022
@BZanten
Copy link
Contributor

BZanten commented Sep 5, 2022

Hi ataumo I'm quite confused by the pull request. Are you meaning quiet instead of QuiteMode ? (Meaning you want the output to be more quiet or something). please do not introduce spelling errors in the syntax.
And consider: PowerShell has a default verbose properties, and write-verbose. So maybe you are requesting the script to put more output in the Verbose channel that you can enable or disable as you like..

@BZanten
Copy link
Contributor

BZanten commented Sep 6, 2022

in addition...
if ($Quite -eq 0) {

You specify $Quite as a switch, meaning it is a boolean variable. Thus you should compare the variable with a boolean, not with an integer.
(Apart from the fact that you typed $Quite but mean: $Quiet

@ataumo ataumo changed the title Add Quite Mode And QuiteOption Add Quiet Mode And QuietOption Sep 6, 2022
@ataumo
Copy link
Contributor Author

ataumo commented Sep 6, 2022

@0x6d69636b

Thanks for the PR and the input. I have been thinking about fundamentally revising the output and writing of reports/logs and will include a slient mode as a feature. It's already complicated at the moment and with your changes it will be even more complex. However, I would like to simplify output management. Stay tuned :)

Okay no problems :)

@BZanten

Hi ataumo I'm quite confused by the pull request. Are you meaning quiet instead of QuiteMode ? (Meaning you want the output to be more quiet or something). please do not introduce spelling errors in the syntax.

Yes sorry, it's a QuietMode. It was a big mistake

And consider: PowerShell has a default verbose properties, and write-verbose. So maybe you are requesting the script to put more output in the Verbose channel that you can enable or disable as you like..

Yes but I'm looking for the exact opposite of the verbose properties. I want less outputs.

You specify $Quite as a switch, meaning it is a boolean variable. Thus you should compare the variable with a boolean, not with an integer.
(Apart from the fact that you typed $Quite but mean: $Quiet

Fixed.

@ataumo ataumo changed the title Add Quiet Mode And QuietOption Add Quiet Mode And Quiet Option Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants