Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The entire app example is rerendered every frame of the animation #18

Open
jrmuizel opened this issue Apr 23, 2018 · 2 comments
Open

The entire app example is rerendered every frame of the animation #18

jrmuizel opened this issue Apr 23, 2018 · 2 comments

Comments

@jrmuizel
Copy link

It's not exactly clear why.
https://perfht.ml/2vEbUc6

styled-components makes it harder to understand what's going on.
@zzarcon
Copy link
Owner

zzarcon commented Apr 26, 2018

@jrmuizel thanks for reporting that. Can you please confirm that the app still re-rendering? did some profiling locally and couldn't reproduce

@jrmuizel
Copy link
Author

Yep, you can see it's still spending ~15ms running script. https://perfht.ml/2r0AnDw.
What were you using to profile? What did your profile look like?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrmuizel @zzarcon