Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator image broken when config.validator_enabled set to false #19

Open
aert opened this issue Dec 14, 2017 · 1 comment · May be fixed by #38
Open

Validator image broken when config.validator_enabled set to false #19

aert opened this issue Dec 14, 2017 · 1 comment · May be fixed by #38
Labels
help wanted
Projects
Swagger UI Engine for Ruby on Rails
Milestone
1.1.2

Comments

@aert
Copy link

aert commented Dec 14, 2017

First of all thank you @zuzannast for this excellent plugin, very needed and easy to setup.

There is a small issue when validator_enabled is set false, it looks like it's still trying to do a validation but with an url set to null?<path_to_yaml_file>

Additionally a config option to customize the URL of validationUrl would be nice, as well as having the latest version (3.6) of SwaggerUI.

I'll try to send a PR the following week.
@zuzannast
Copy link
Owner

Hey @aert, how's the work on this one going?

@zuzannast zuzannast added this to the 1.1.2 milestone Feb 8, 2018
@ozmar-11 ozmar-11 mentioned this issue Aug 8, 2019
Merged
@zuzannast zuzannast linked a pull request Sep 9, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
Swagger UI Engine for Ruby on Rails
TODO
Milestone
1.1.2
Development

Successfully merging a pull request may close this issue.

1.1.4 version zuzannast/swagger_ui_engine
2 participants
@aert @zuzannast