Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New directory for extra tests #14

Open
sdanailo-42 opened this issue Mar 21, 2024 · 1 comment · May be fixed by #15
Open

New directory for extra tests #14

sdanailo-42 opened this issue Mar 21, 2024 · 1 comment · May be fixed by #15
Labels
enhancement New feature or request

Comments

@sdanailo-42
Copy link
Contributor

sdanailo-42 commented Mar 21, 2024 •
edited
Loading

In our PDF a case like /bin/echo \$USER should not be covered, since it states that \ shouldn't be covered at all. Same goes for env -i $MINISHELL_PATH"/"$EXECUTABLE, since env should not accept any options or arguments. I'm assuming the PDF for all campuses is the same.

Should we create a new folder called extra where we move all of those tests there, to prevent confusion, but still keep them for people who want to try them, since this is not mandatory to cover?
@zstenger93
Copy link
Owner

Maybe, but it's a minor thing. If you are that bored, you are welcome :D
Env -i is only there to check for segfaults which you can protect in like 2 minutes or take the challenge and make it work, you will see interesting things.
The same goes for the escape characters.

@zstenger93 zstenger93 added the enhancement New feature or request label Mar 21, 2024
@sdanailo-42 sdanailo-42 linked a pull request Mar 21, 2024 that will close this issue
Open
@zstenger93 zstenger93 linked a pull request Mar 21, 2024 that will close this issue
Move all tests not required by the PDF into a new folder called extra #15
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@zstenger93 @sdanailo-42