Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme building guidelines & process? #114

Open
Milanzor opened this issue Feb 5, 2018 · 0 comments
Open

Theme building guidelines & process? #114

Milanzor opened this issue Feb 5, 2018 · 0 comments

Comments

@Milanzor
Copy link
Contributor

Milanzor commented Feb 5, 2018

The current CSS structure does not really support creating new themes.

Currently, in the src/client/styles folder, there is a themes/default folder. The files in there are always loaded and used as the theme. There is no way to make a new theme without either not loading the default theme or loading the default theme AND a new theme, having your own theme overrule the default css variables.

Also there is no way to tell JARVIS what theme to use when instantiating in a Webpack config.
Wouldn't it be great like this:

new Jarvis({
    theme: 'light'
});

What is the expected way for someone to make a theme? I have some idea's but I'd be wasting time if you already have work in progress for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants