From 66cb9ce0a633735d81a9cb3e4f8403de87ff3f73 Mon Sep 17 00:00:00 2001
From: Marc Worrell <marc@worrell.nl>
Date: Fri, 31 May 2024 17:41:43 +0200
Subject: [PATCH] Some dialyzer fixes

---
 src/mqtt_sessions_process.erl         | 15 ++++-----------
 test/mqtt_sessions_protocol_SUITE.erl |  2 +-
 2 files changed, 5 insertions(+), 12 deletions(-)

diff --git a/src/mqtt_sessions_process.erl b/src/mqtt_sessions_process.erl
index 786d542..fd02a27 100644
--- a/src/mqtt_sessions_process.erl
+++ b/src/mqtt_sessions_process.erl
@@ -747,7 +747,8 @@ packet_pubrec(#{ packet_id := PacketId }, #state{ awaiting_ack = WaitAck } = Sta
         {ok, #wait_for{ msg_nr = MsgNr, type = pubrec }} ->
             WaitFor = #wait_for{
                 msg_nr = MsgNr,
-                type = pubcomp
+                type = pubcomp,
+                queued = mqtt_sessions_timestamp:timestamp()
             },
             {WaitAck#{ PacketId => WaitFor }, ?MQTT_RC_SUCCESS};
         {ok, #wait_for{ type = pubcomp }} ->
@@ -1083,8 +1084,6 @@ disconnect_transport(#state{ transport = {M, F, A} } = State) ->
     erlang:apply(M, F, [disconnect | A]),
     State#state{ transport = undefined, is_connected = false }.
 
-reply_to_transport(undefined, State) ->
-    State;
 reply_to_transport(_Msg, #state{ transport = undefined } = State) ->
     State;
 reply_to_transport(Msg, State) ->
@@ -1095,8 +1094,6 @@ reply_to_transport(Msg, State) ->
             force_disconnect(State)
     end.
 
-reply_or_drop(undefined, State) ->
-    State;
 reply_or_drop(_Msg, #state{ is_connected = false } = State) ->
     State;
 reply_or_drop(Msg, State) ->
@@ -1107,8 +1104,6 @@ reply_or_drop(Msg, State) ->
             force_disconnect(State)
     end.
 
-reply_or_queue(undefined, _MsgNr, State) ->
-    State;
 reply_or_queue(Msg, MsgNr, #state{ is_connected = false } = State) ->
     maybe_purge( queue(Msg, MsgNr, State) );
 reply_or_queue(Msg, MsgNr, State) ->
@@ -1172,7 +1167,7 @@ maybe_purge_ack(WaitAcks) ->
         end,
         WaitAcks).
 
-maybe_purge_buffer(Buffer) ->
+maybe_purge_buffer(Buffer) when is_map(Buffer) ->
     case maps:size(Buffer) > ?MAX_BUFFERED of
         true -> purge_buffer(Buffer);
         false -> Buffer
@@ -1213,9 +1208,7 @@ purge_buffer(Buffer) ->
 -spec encode( mqtt_packet_map:mqtt_version(), mqtt_packet_map:mqtt_packet() | list( mqtt_packet_map:mqtt_packet() )) -> binary().
 encode(ProtocolVersion, Msg) when is_map(Msg) ->
     {ok, Bin} = mqtt_packet_map:encode(ProtocolVersion, Msg),
-    Bin;
-encode(ProtocolVersion, Ms) when is_list(Ms) ->
-    iolist_to_binary([ encode(ProtocolVersion, M) || M <- Ms ]).
+    Bin.
 
 
 %% @doc Set the new connection, disconnect existing transport.
diff --git a/test/mqtt_sessions_protocol_SUITE.erl b/test/mqtt_sessions_protocol_SUITE.erl
index 8629a00..bff1c1d 100644
--- a/test/mqtt_sessions_protocol_SUITE.erl
+++ b/test/mqtt_sessions_protocol_SUITE.erl
@@ -9,7 +9,7 @@
 -dialyzer({nowarn_function, connect_disconnect_v5_test/1}).
 -dialyzer({nowarn_function, connect_reconnect_v5_test/1}).
 -dialyzer({nowarn_function, connect_reconnect_clean_v5_test/1}).
-
+-dialyzer({nowarn_function, connect_reconnect_buffered_v5_test/1}).
 
 %%--------------------------------------------------------------------
 %% COMMON TEST CALLBACK FUNCTIONS