Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The order of sorting transactions is not defined. #19

Open
DronMDF opened this issue Jun 13, 2018 · 5 comments
Open

The order of sorting transactions is not defined. #19

DronMDF opened this issue Jun 13, 2018 · 5 comments

Comments

@DronMDF
Copy link

DronMDF commented Jun 13, 2018

TLDR: In my opinion, we need rules for recognizing transactions as invalid. And the remaining transactions just sorted, so it was beautiful. :)

I see several cases that are not described in the WP.
In chapter 8 the order of mergers is described.

2. If the transaction is negative (spending money) and its ID is lower
than the maximum ID in the ledger, it gets ignored as a fraudulent
one (“double spending”);

This is not blockchain. This is not problem. There may be situations where transaction 5 enters the network earlier than transaction 4. I do not see this problem if there is enough money in the wallet. This can happen if the client is decentralized. The identifier does not make sense at all...

If the value has only the overall balance of the wallet - then we generally can sort everything in time. Although this is not accurate. :)

@0crat
Copy link

0crat commented Jun 13, 2018

@yegor256/z please, pay attention to this issue

@0crat
Copy link

0crat commented Jun 13, 2018

@DronMDF/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

@yegor256
Copy link
Contributor

@DronMDF so you are saying that we can get rid of transaction ID entirely?

@DronMDF
Copy link
Author

DronMDF commented Jun 27, 2018

@yegor256 No, no...

One wallet can be used on different workstations for payments. It can sharing (For automation payment system for example). Should I require that these nodes support only sequential numbering of transactions? This is superfluous in my opinion. Let in a purse there will be some transactions with identical numbers. It's not a problem if you have enough money.

But the sufficiency of means can be checked more rigidly ... Not on the total balance, but transaction by transactions. For this, it is necessary that the nodes arrange the transactions in the identical order. To avoid unnecessary refusals.

@yegor256
Copy link
Contributor

@DronMDF yes, currently it's designed the way you can use one wallet only on one machine. You can't send payments from the same wallet from different machines, because you need to number transactions sequentially. I see your point -- we can get rid of IDs and just sort them by their time. It is indeed possible...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants