Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet merging of copies #70

Open
Vatavuk opened this issue Aug 9, 2018 · 7 comments
Open

Wallet merging of copies #70

Vatavuk opened this issue Aug 9, 2018 · 7 comments
Labels
bug Something isn't working scope
Milestone

Comments

@Vatavuk
Copy link
Contributor

Vatavuk commented Aug 9, 2018

According to the whitepaper merging of two wallets is an operation of merging copies into a local one.
Merge algorithm first sorts the copies and then merges transactions from that copies.
Currently, sorting is done outside Wallet.merge() method. It is part of Remote.pull() method.
I propose to add an additional method to Wallet : Wallet merge(Copies copies) and remove explicit sorting from Remote.pull().
Similar to what we have in ruby version

@0crat
Copy link
Collaborator

0crat commented Aug 9, 2018

@llorllale/z please, pay attention to this issue

@0crat
Copy link
Collaborator

0crat commented Aug 9, 2018

There is an unrecoverable failure on my side. Please, submit it here:

PID: 4@8ff2a38c-103c-4d3f-89c6-ae548aaac564, thread: pool-219-thread-1
com.zerocracy.radars.github.ThrottledComments[74] java.lang.IllegalStateException: Can't post an identical message to zold-io/java-api#70: @llorllale[/z](https://www.0crat.com/u/llorllale) please, pay attention to this issue

0.29.8: Issue: #70, Action: opened

@llorllale
Copy link
Collaborator

@Vatavuk agreed. I also think Copy should be a Wallet with the existing, extra attribute score().

@llorllale llorllale added the bug Something isn't working label Aug 12, 2018
@llorllale llorllale added this to the 1.0 milestone Aug 12, 2018
@0crat 0crat added the scope label Aug 12, 2018
@0crat
Copy link
Collaborator

0crat commented Aug 12, 2018

Job #70 is now in scope, role is DEV

@llorllale
Copy link
Collaborator

@0crat in

@0crat
Copy link
Collaborator

0crat commented Aug 12, 2018

Bug was reported, see §29: +15 point(s) just awarded to @Vatavuk/z

@0crat
Copy link
Collaborator

0crat commented Aug 12, 2018

@0crat in (here)

@llorllale Job #70 is already in scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working scope
Projects
None yet
Development

No branches or pull requests

3 participants