-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wallet merging of copies #70
Comments
@llorllale/z please, pay attention to this issue |
There is an unrecoverable failure on my side. Please, submit it here:
|
@Vatavuk agreed. I also think |
Job #70 is now in scope, role is |
@0crat in |
@llorllale Job #70 is already in scope |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
According to the whitepaper merging of two wallets is an operation of merging
copies
into a local one.Merge algorithm first sorts the
copies
and then merges transactions from that copies.Currently, sorting is done outside
Wallet.merge()
method. It is part ofRemote.pull()
method.I propose to add an additional method to
Wallet
:Wallet merge(Copies copies)
and remove explicit sorting fromRemote.pull()
.Similar to what we have in ruby version
The text was updated successfully, but these errors were encountered: