Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the deprecation of the redirect_uri_path option #496

Open
voronin-ilya opened this issue Nov 15, 2023 · 0 comments
Open

Revert the deprecation of the redirect_uri_path option #496

voronin-ilya opened this issue Nov 15, 2023 · 0 comments

Comments

@voronin-ilya
Copy link

Environment
Expected behaviour

The OAuth provider I am using mandates that the redirect_uri be a relative path (/user/${user}/oauth_callback), and this setting cannot be altered on the provider's end. I anticipated the ability to configure lua-resty-openidc accordingly.

Actual behaviour

I had to modify the code because currently, the redirect_uri (and redirect_uri_path) is invariably transformed into an absolute URL.

voronin-ilya@381c7ce

Proposal

To ensure compatibility with the JupyterHub OAuth provider, I propose rolling back the deprecation of the redirect_uri_path option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant