-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attribute behaves differently than annotation in case of DocBlockDescriptions #1668
Comments
A bit more detail might be good. 'doesn't work's could be anything... Best guess is you are facing this issue: https://zircote.github.io/swagger-php/guide/faq.html#warning-required-oa-info-not-found |
@DerManoMann right. here is my use case. i have a enum class annotated with attribute:
When API docs are generated, also enum class docblock is parsed and included in generated docs. However as this docblock contains internal info which should not be exposed i tried to set
But still the docblock is included in API docs. |
Ah, yes, sorry. Was reading this on my phone and didn't scroll right :/ The attributes do not use |
I wonder if for attributes all properties typed |
dont really know the internals of this library but as a library consumer i would expect same behavior no matter what "annotating interface" i am using |
Fair enough - will do some more digging then ;) |
There is actually no way to distinguish a user provided To allow sensible typehints for attribute properties the default value is To more align annoations and attributes I would think that treating Since this is an API change I think this change will only go into the 5x-dev branch. |
This works:
this dont:
The text was updated successfully, but these errors were encountered: