Skip to content
This repository has been archived by the owner on Sep 17, 2022. It is now read-only.

Fill out PackageModule with all functions required by Morphir.IR.Package #30

Open
michelchan opened this issue Feb 11, 2022 · 0 comments
Open

Fill out PackageModule with all functions required by Morphir.IR.Package #30

michelchan opened this issue Feb 11, 2022 · 0 comments
Assignees
@michelchan
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@michelchan
Copy link
Collaborator

michelchan commented Feb 11, 2022 •
edited by DamianReeves
Loading

We need to support in principal the same operations in the PackageModule as those that are in Morphir.SDK.Package.

We should support the Morphir.IR.Package module.

NOTE: Please note we want to support the functions in spirit in the modules, but we should also think about Scala ergonomics. One suggestion here is to use methods on our types and implement the functions in terms of those methods (similar to what was done with other files like Name and Path).
@michelchan michelchan added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 11, 2022
@michelchan michelchan mentioned this issue Mar 16, 2022
Merged
@michelchan michelchan self-assigned this Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michelchan michelchan

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michelchan