-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve OpenTelemetry integration so traces include path #2835
Labels
Comments
SimunKaracic
changed the title
Improve OpenTelemetry integration so traces include path.
Improve OpenTelemetry integration so traces include path
May 8, 2024
/bounty $150 |
💎 $150 bounty • ZIOSteps to solve:
Thank you for contributing to zio/zio-http! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
When using the OTEL agent with ZIO-http, we get the benefit of existing Netty instrumentation. This means traces are started/stopped and propagated correctly, but there's a problem.
The server trace names contain only the HTTP method (which is useless, we need the route in the trace name).
From what I can tell, we're hitting the same issue as described here open-telemetry/opentelemetry-java-instrumentation#8613
We need to add instrumentation to the OTEL agent that provides the span name.
This involves hooking into specific classes and methods in ZIO-http.
Describe the solution you'd like
Someone from the core team decides if there's enough stability in the internal API to hook into it with the OTEL java agent.
And if there is, you can provide me the classes/methods where I can see the matched route and I'll try and add the required instrumentation to OTEL.
Describe alternatives you've considered
Someone from the core team writes a plugin and I don't have to do anything? :D
The text was updated successfully, but these errors were encountered: