Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to cover more complex scenarios and cross-platform cases. #54

Open
ithinkicancode opened this issue Sep 27, 2021 · 2 comments

Comments

@ithinkicancode
Copy link
Contributor

Motivation

Currently the test cases are pretty simple. More complex scenarios should be covered. Additionally tests for other platforms (namely JS and native) should also be added to make sure behaviors on those platforms are within our expectation.

@adamgfraser
Copy link
Contributor

In general we shouldn't be adding platform specific tests. We should be presenting a consistent cross platform interface and our tests should pass on all platforms. Definitely agree about more tests being great though!

@ithinkicancode
Copy link
Contributor Author

I agree. Platform-specific tests should be avoided. That thought stemmed from that scenario I had with JS test case and our convos on Discord. But I agree that should be avoided. And at the moment, I don't think we need platform-specific tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants