New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--release=x
ignored when preferred_optimize_mode
is set
#19732
Comments
I wrote this on the PR but I think here is better: This is already working as designed, although clearly the flag names do not make this self-evident. How it currently stands is that there are two parties communicating their preference to the build system:
The build system gives the upstream maintainer's preference priority of these two options. However, the application may also expose additional options. |
if this is true I think the issue should stand and the upstream's preferences should never take priority over this flag. imo it should go
|
(Moving my comment from IRC.) |
Another alternative: Remove |
Zig Version
0.13.0-dev.4+c7ffdbcd4
Steps to Reproduce and Observed Behavior
I had set
preferred_optimize_mode
in ncdu's build.zig in order to provide a good default when building in release mode, but this causes a custom--release=x
flag to be ignored:(Throwing away all build files and clearing caches in between the two builds doesn't affect the result)
Expected Behavior
--release=x
option is respected.The text was updated successfully, but these errors were encountered: