Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the payload parameter with message #233

Open
fadeev opened this issue Jul 17, 2024 · 2 comments
Open

Replace the payload parameter with message #233

fadeev opened this issue Jul 17, 2024 · 2 comments

Comments

@fadeev
Copy link
Member

fadeev commented Jul 17, 2024

function depositAndCall(address receiver, bytes calldata payload) external payable {

We have "payload" in the depositAndCall and "message" in the onCrossChainCall. For consistency, we should use the same name.

@lumtis
Copy link
Member

lumtis commented Jul 17, 2024

I think the reasoning of using payload in depositAndCall was to differentiate from message in withdrawAndCall to highlight the difference that withdrawAndCall enable a arbitrary smart contract call while for the payload we call onCrossChainCall
And we inadvertently used message in onCrossChainCall

I think it makes sense to continue on this choice and call it payload in onCrossChainCall

@fadeev
Copy link
Member Author

fadeev commented Jul 17, 2024

Hm, but it's also very intuitive that messages are being sent to universal contracts, and from universal contracts to contracts on connected chains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants