Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @solana/web3.js to 1.95.5 #68

Open
CharlieMc0 opened this issue Dec 4, 2024 · 1 comment
Open

Bump @solana/web3.js to 1.95.5 #68

CharlieMc0 opened this issue Dec 4, 2024 · 1 comment
Assignees

Comments

@CharlieMc0
Copy link
Member

Bump @solana/web3.js to 1.95.5 or 1.95.8 & check to make sure it is updated across all other repos.

https://zetachain.slack.com/archives/C02RNH23T26/p1733322592975429

@0xM3R
Copy link

0xM3R commented Dec 10, 2024

I have just issued pull requests to all repos that are using the @solana/web3.js as a dependency.
Zeta Apps: pr link
Example Contracts: pr link
Toolkit: pr link
The toolkit won't compile because one package @coral-xyz/anchor has its own version of @solana/web3.js, which is incompatible with the version 1.95.5 and 1.95.8.

npm info @coral-xyz/anchor dependencies | grep "@solana/web3.js"
  '@solana/web3.js': '^1.68.0',

Library won't be imported correctly https://github.com/zeta-chain/toolkit/pull/202/files#annotation_29523945262 if @solana/web3.js > 1.95.3 is used.

Argument of type 'import("/home/runner/work/toolkit/toolkit/node_modules/@coral-xyz/anchor/node_modules/@solana/web3.js/lib/index").Connection' is not assignable to parameter of type 'import("/home/runner/work/toolkit/toolkit/node_modules/@solana/web3.js/lib/index").Connection'.
Argument of type 'import("/home/runner/work/toolkit/toolkit/node_modules/@solana/web3.js/lib/index").Keypair' is not assignable to parameter of type 'import("/home/runner/work/toolkit/toolkit/node_modules/@coral-xyz/anchor/node_modules/@solana/web3.js/lib/index").Keypair'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants