You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Version 0.2.0 renders the left margin differently than version 0.1.5. See an example from application:
With version 0.1.5:
Error: error: global rule `test_2` depends on non-global rule `test_1`
╭─[test.yar:25:5]
│
8 │ rule test_1 {
· ───┬──
· ╰──── non-global rule `test_1` declared here
·
23 │ global rule test_2 {
· ───┬──
· ╰──── global rule `test_2` declared here
·
25 │ test_1
· ───┬──
· ╰──── `test_1` is used in the condition of `test_2`
────╯
With version 0.2.0:
error: global rule `test_2` depends on non-global rule `test_1`
╭─[test.yar:25:5]
│
8 │ rule test_1 {
│ ───┬──
│ ╰──── non-global rule `test_1` declared here
│
23 │ global rule test_2 {
│ ───┬──
│ ╰──── global rule `test_2` declared here
│
25 │ test_1
│ ───┬──
│ ╰──── `test_1` is used in the condition of `test_2`
────╯
Version 0.1.5 uses dotted lines as a visual indication of missing lines, while in version 0.2.0 the dotted lines disappeared and the result is an error report that is less clear than before.
I believe this an unintended change that was introduced here when draw.vbar_break was replaced with draw.vbar.
Or perhaps the intention was replacing the dotted lines with a solid line in a different color? If that's the case I would say that the dotted line (possibly on a different color too) is a better alternative, as it works in monochrome environments as well.
The text was updated successfully, but these errors were encountered:
This is a good point, I didn't consider monochrome environments. I think it would be a fairly trivial change to introduce a 'margin style' parameter that can be configured via Config. I'd be very happy to accept a PR for this. Alternatively, I can put it on my backlog to be done when I can find time.
Version
0.2.0
renders the left margin differently than version0.1.5
. See an example from application:With version
0.1.5
:With version
0.2.0
:Version
0.1.5
uses dotted lines as a visual indication of missing lines, while in version0.2.0
the dotted lines disappeared and the result is an error report that is less clear than before.I believe this an unintended change that was introduced here when
draw.vbar_break
was replaced withdraw.vbar
.Or perhaps the intention was replacing the dotted lines with a solid line in a different color? If that's the case I would say that the dotted line (possibly on a different color too) is a better alternative, as it works in monochrome environments as well.
The text was updated successfully, but these errors were encountered: