Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should escape control characters #21

Open
hmh opened this issue Mar 13, 2023 · 0 comments
Open

should escape control characters #21

hmh opened this issue Mar 13, 2023 · 0 comments

Comments

@hmh
Copy link

hmh commented Mar 13, 2023

Although the code is capable of escaping a few control characters, it is not checking for them before it decides whether output should be escaped or not (Unicode codepoints 0000h to 001fh), so they make it to the output as-is (unquoted).

To test, add \u000a to the value of any of the unquoted fields in the example.

Fixing this would be extremely trivial and the slowdown should be negligible (unlike, say, really fixing it for all Unicode control characters).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant