This repository has been archived by the owner on Jun 2, 2022. It is now read-only.
Support yml extension and remove mandatory file pattern #155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
the restrictions on the secret names are very counter-intuitive. e.g.:
this fails, because
yml
is not supported. Additionally, the secret gets deleted with this :(Currently the secret has to conform the following regex:
^secrets(.[^.]+)*.yaml$
This pull request removes the restriction completely and allows any *.yml / *.yaml to be processed.
Instead of relying on the filename the content of the file is checked to verify that it is a sops encrypted file.
Resolves #124, resolves #128