Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline completions show up in vim during normal mode #22343

Open
1 task done
zeux opened this issue Dec 21, 2024 · 2 comments · May be fixed by #22439
Open
1 task done

Inline completions show up in vim during normal mode #22343

zeux opened this issue Dec 21, 2024 · 2 comments · May be fixed by #22439
Labels
admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue

Comments

@zeux
Copy link
Contributor

zeux commented Dec 21, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Using de motion to erase a word can show the same word again as an inline completion (when using Vim in normal mode). I'm fairly sure this never happened until the last update or so; I first noticed this on Zed 166.1 and confirmed this also happens on 167.1 preview, but not sure when the bug appeared first.

Wondering if this is related to #22075, although it looks as if that was reverted later.

Zed Version and System Specs

Zed: v0.166.1 (Zed)
OS: Linux Wayland ubuntu 24.10
Memory: 184.2 GiB
Architecture: x86_64
GPU: AMD Radeon RX 7900 GRE || AMD open-source driver || 2024.Q4.2 (LLPC)

If applicable, add screenshots or screencasts of the incorrect state / behavior

I press de in the beginning of the screencast, and also later undo that change and do it again.

Screencast.From.2024-12-21.15-05-07.webm

If applicable, attach your Zed.log file to this issue.

Zed.log
@zeux zeux added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Dec 21, 2024
@dongnez
Copy link

dongnez commented Dec 22, 2024

Have the same issue, pls fix this

@github-actions github-actions bot mentioned this issue Dec 22, 2024
Open
@zeux
Copy link
Contributor Author

zeux commented Dec 22, 2024

I've bisected this to 77b8296 (#21739). Which is to say, I can reproduce this on 77b8296 as shown above, but not on its parent commit. fyi @as-cii

(I'm not sure why the logic in this commit activates for non-staff, but I guess more importantly these should be suppressed in normal mode...)

@zeux zeux linked a pull request Dec 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable inline completions in Vim normal mode zeux/zed
2 participants
@zeux @dongnez