Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning dialog with timer after settings "base_keymap": "None" #22421

Open
1 task done
feelamee opened this issue Dec 25, 2024 · 1 comment
Open
1 task done

Warning dialog with timer after settings "base_keymap": "None" #22421

feelamee opened this issue Dec 25, 2024 · 1 comment
Labels
admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue

Comments

@feelamee
Copy link
Contributor

Check for existing issues

  • Completed

Describe the feature

Problem:

After setting "base_kemap" to "None" all bindings (except custom ofc) will be disabled.
To return them you need open config in another editor and modify "base_keymap" value.

Solution I suggest

Open dialog with timer and confirm button after settings "base_keymap": "None".
After timer will be expired "base_keymap" should be returned to previous value.
If confirm was pressed before expiration, then "None" should remains.

There is nothing functional or else - just to improve user experience.
F.e. I saw such dialog in Windows when changing screen rotating.

Probably, I'm ready to contribute solution if someone like this and can set me on the right path to.

Zed Version and System Specs

isn't necessarily for this feature

If applicable, add mockups / screenshots to help present your vision of the feature

image

Sorry for watermark, haha - I have no windows))

@feelamee feelamee added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Dec 25, 2024
@0x2CA
Copy link
Contributor

0x2CA commented Dec 26, 2024

I don't think this is feasible, how can the user confirm that the keymap is invalid? This is just to prevent the wrong display settings of the window system from causing the user to not see the popup window, the display can be restored after a timeout. How can the user be sure that the user has made an incorrect change to the keymap?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue
Projects
None yet
Development

No branches or pull requests

2 participants