Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Blade with acquire fixes, multisampling #22409

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Update Blade with acquire fixes, multisampling #22409

merged 1 commit into from
Dec 27, 2024
+306 −67

Conversation

kvark
Copy link
Contributor

@kvark kvark commented Dec 25, 2024 •
edited
Loading

Fixes #22406

Picks up:

Release Notes:

  • Improved handling of resizing and multiple monitors in Linux/Windows

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 25, 2024
@kvark kvark mentioned this pull request Dec 25, 2024
Open
1 task
@s3bba
Copy link
Contributor

s3bba commented Dec 25, 2024

@kvark Thanks for a quick response on the issue, I tested this PR and SIGSEGV is gone but window never renders and this appears in the logs: [2024-12-25T09:22:59+01:00 ERROR gpui::platform::blade::blade_renderer] GPU hung

@kvark
Copy link
Contributor Author

kvark commented Dec 25, 2024

@s3bba this is very helpful, thank you! Would you be able to test with Vulkan validation enabled? If you have the relevant packages installed in the system, enabling validation can be done through this flag -

zed/crates/gpui/src/platform/blade/blade_context.rs

Line 15 in 1a9f0a6

validation: false,

@s3bba
Copy link
Contributor

s3bba commented Dec 25, 2024

Yeah, I'm around for few more hours today so we can try to debug this - here is the output with validation enabled, compiled with: RUSTFLAGS="-Ctarget-cpu=native" cargo build --profile release-fast

[2024-12-25T09:57:04+01:00 INFO  gpui::platform::linux::x11::client] Refreshing at 16666 micros
[2024-12-25T09:57:04+01:00 INFO  gpui::platform::linux::x11::window] x11: no compositor present, falling back to server-side window decorations
[2024-12-25T09:57:04+01:00 INFO  zed::zed] Using GPU: GpuSpecs { is_software_emulated: false, device_name: "Quadro P1000", driver_name: "NVIDIA", driver_info: "565.77" }
[2024-12-25T09:57:04+01:00 INFO  blade_graphics::hal::resource] Creating texture 0x64eade8eb0a0 of size 1024x1024x1 and format R8Unorm, name 'atlas', handle 1
[2024-12-25T09:57:04+01:00 INFO  blade_graphics::hal::resource] Creating buffer 0x64eade8ec5d0 of size 65536, name 'chunk-0', handle 2
[2024-12-25T09:57:04+01:00 INFO  blade_graphics::hal::resource] Creating buffer 0x64eade8d4a70 of size 4096, name 'chunk-0', handle 3
[2024-12-25T09:57:04+01:00 INFO  blade_graphics::hal::resource] Creating buffer 0x64eade87d220 of size 6272, name 'chunk-1', handle 4
[2024-12-25T09:57:04+01:00 WARN  blade_graphics::hal::command] GPU frame is out of date
[2024-12-25T09:57:04+01:00 WARN  blade_graphics::hal::surface] Acquire failed because the surface is out of date
[2024-12-25T09:57:04+01:00 WARN  blade_graphics::hal::command] GPU frame is out of date
[2024-12-25T09:57:14+01:00 ERROR gpui::platform::blade::blade_renderer] GPU hung

@kvark
Copy link
Contributor Author

kvark commented Dec 25, 2024

@s3bba thank you! It doesn't look like Vulkan Validation was activated, or it just didn't detect anything wrong.
In any case, I figured another thing that could go wrong there and merged a fix in kvark/blade#237
This PR is now picking it up as well. If you can check the latest of this PR, that would be great!

@s3bba
Copy link
Contributor

s3bba commented Dec 26, 2024

@kvark Can confirm, the GPU hang error is gone and I haven't fond any new issues. Thank you!

@kvark
Copy link
Contributor Author

kvark commented Dec 27, 2024

@ConradIrwin let's get this in?

@ConradIrwin ConradIrwin added this pull request to the merge queue Dec 27, 2024
@ConradIrwin
Copy link
Member

👍

Merged via the queue into zed-industries:main with commit 02cc0b9 Dec 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SIGSEGV (Address boundary error) with dwm
3 participants
@kvark @s3bba @ConradIrwin