Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not catch not-used/-binded hotkeys #22395

Open
1 task done
boozook opened this issue Dec 24, 2024 · 1 comment
Open
1 task done

Do not catch not-used/-binded hotkeys #22395

boozook opened this issue Dec 24, 2024 · 1 comment
Labels
admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue

Comments

@boozook
Copy link

boozook commented Dec 24, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

On any macOs,
seems to Zed catches all key-strokes including non-binded ones, e.g. 'cmd+shift+/' hotkey by-default have to focus app-menu/help- search-text-field.

I have no see anything like that in the Zed's key-bindings, but found 'cmd-/' (without shift) default hotkey, so problem may be there. Anyway, as I suppose, the possible way to fix it - to return the event from the key-event- handler (NSEvent) if hotkey not found (not binded), otherwise return nil (in cocoa that means "event accepted").


Steps to reproduce:

  • in the Zed unbind all hotkeys that catches 'cmd+shift+/'
  • anywhere in Zed press 'cmd+shift+/'

Expected result:
Screenshot 2024-12-24 at 19 17 55

Actual result is nothing because Zed catches the event.

Zed Version and System Specs

Zed: v0.166.1 (Zed)
OS: macOS 14.7.1
Memory: 16 GiB
Architecture: aarch64

@boozook boozook added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Dec 24, 2024
@boozook
Copy link
Author

boozook commented Dec 24, 2024

Update:

  1. I was wrong, 🤦🏻‍♂️sorry. Zed correctly returning not-matched (not catched) events, so problem is simpler - just default hotkey "cmd-?": "assistant::ToggleFocus" which conflicts with default in macOs.

  2. I've found workaround. Just remap in user's key-bindings
    from "cmd-?": "assistant::ToggleFocus" to "cmd-?": null.

Now please interpret this issue as request to change conflicting default hotkey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue
Projects
None yet
Development

No branches or pull requests

1 participant