Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I cannot comment a line in Markdown #19797

Open
1 task done
Rusydy opened this issue Oct 26, 2024 · 3 comments · May be fixed by #22352
Open
1 task done

I cannot comment a line in Markdown #19797

Rusydy opened this issue Oct 26, 2024 · 3 comments · May be fixed by #22352
Labels
bug [core label] enhancement [core label] markdown Markdown markup support

Comments

@Rusydy
Copy link

Rusydy commented Oct 26, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

I cannot comment a line in Markdown file using cmd+/ or any combination. I have read the list on key-bindings, but none of them makes me can comment a line in Markdown. Interestingly, I can use cmd+/ on XML file.

Environment

Darwin Users-MacBook-Pro.local 24.0.0 Darwin Kernel Version 24.0.0: Tue Sep 24 23:37:13 PDT 2024; root:xnu-11215.1.12~1/RELEASE_ARM64_T8112 arm64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log
@Rusydy Rusydy added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Oct 26, 2024
@CharlesChen0823
Copy link
Contributor

I'm curious about what's the comment in Markdown file? other langauge comment is using tree-sitter.

@Rusydy
Copy link
Author

Rusydy commented Oct 28, 2024

I am not quite get the question, but like I write before I cannot use this cmd+/ command shortcut to comment out a line and I have to manually type it.

<!-- This is comment-->

If I may to contribute to solve this. In which file should I start?

@CharlesChen0823
Copy link
Contributor

because,previously, i don't known what's the comment in Markdown file. And then I searched, <!-- This is comment --> might is extension grammar of markdown.

you can add block_comment = ["<!-- ", " -->"] in file crates/languages/src/markdown/config.toml, I am not sure if this is acceptable.

I tested, there is an crashed when you toggle comment with markdown where exists non-english language in comment line.

you can try and debug it.

@notpeter notpeter added enhancement [core label] markdown Markdown markup support and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] enhancement [core label] markdown Markdown markup support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants