-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cube package #202
cube package #202
Conversation
🦋 Changeset detectedLatest commit: bbc237d The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #202 +/- ##
==========================================
- Coverage 92.58% 91.94% -0.65%
==========================================
Files 207 199 -8
Lines 11159 10619 -540
==========================================
- Hits 10332 9764 -568
- Misses 827 855 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -7,12 +7,12 @@ | |||
rdfs:label "SPARQL Select"; | |||
rdfs:comment "Runs the given CONSTRUCT query against the given endpoint parses the result."; | |||
code:implementedBy [ a code:EcmaScriptModule; | |||
code:link <node:barnard59-sparql#construct.js#default> | |||
code:link <node:barnard59-sparql/construct.js#default> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was a mistake before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guess so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then we'd also need to bump the version here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
( | ||
_:queryConstraint | ||
[ ntriples:serialize () ] | ||
_:stdout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need an explicit stdout
step. That is the default behavior
_:stdout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure about this, I'll try again but I think I already tried and got no output
] | ||
. | ||
|
||
# relying on cbd is not ideal (vendor specific) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
We'll replace this with CONSTRUCT
later
_:batch a p:Step ; | ||
code:implementedBy | ||
[ | ||
a code:EcmaScriptModule ; | ||
code:link <file:../lib/batch.js#batch> ; | ||
] ; | ||
code:arguments ("batchSize"^^p:VariableName) | ||
. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't there some step like this in barnard59-base
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apparently not, in fact I would consider adding one (or even two: one for datasets and another for generic objects)
start from version 0.0.0 Co-authored-by: Tomasz Pluskiewicz <[email protected]>
Co-authored-by: Tomasz Pluskiewicz <[email protected]>
Co-authored-by: Tomasz Pluskiewicz <[email protected]>
refactor: no stdout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're good here 👍
A new cube package is created, including operations previously available in the rdf package as well as commands (pipelines) to validate observations and their constraints.