Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cube package #202

Merged
merged 37 commits into from
Nov 22, 2023
Merged

cube package #202

merged 37 commits into from
Nov 22, 2023

Conversation

giacomociti
Copy link
Contributor

A new cube package is created, including operations previously available in the rdf package as well as commands (pipelines) to validate observations and their constraints.

Copy link

changeset-bot bot commented Nov 13, 2023

🦋 Changeset detected

Latest commit: bbc237d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
barnard59-core Minor
barnard59-sparql Patch
barnard59-cube Major
barnard59-rdf Major
barnard59-env Minor
barnard59 Patch
barnard59-graph-store Major
barnard59-test-e2e Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2023

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (5c526f2) 92.58% compared to head (8287ed6) 91.94%.
Report is 3 commits behind head on master.

Files Patch % Lines
packages/validate-shacl/report.js 0.00% 46 Missing ⚠️
packages/cli/lib/discoverManifests.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
- Coverage   92.58%   91.94%   -0.65%     
==========================================
  Files         207      199       -8     
  Lines       11159    10619     -540     
==========================================
- Hits        10332     9764     -568     
- Misses        827      855      +28     
Flag Coverage Δ
barnard59 85.13% <66.66%> (+0.01%) ⬆️
barnard59-base 66.33% <ø> (ø)
barnard59-core 96.54% <ø> (ø)
barnard59-csvw 92.13% <ø> (ø)
barnard59-formats 53.95% <ø> (ø)
barnard59-ftp 91.47% <ø> (ø)
barnard59-graph-store 98.58% <ø> (ø)
barnard59-http 94.19% <ø> (ø)
barnard59-rdf 98.40% <ø> (+0.34%) ⬆️
barnard59-s3 97.56% <ø> (ø)
barnard59-sparql 98.28% <ø> (ø)
barnard59-validate-shacl 80.00% <0.00%> (-17.61%) ⬇️
barnard59-validation 97.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -7,12 +7,12 @@
rdfs:label "SPARQL Select";
rdfs:comment "Runs the given CONSTRUCT query against the given endpoint parses the result.";
code:implementedBy [ a code:EcmaScriptModule;
code:link <node:barnard59-sparql#construct.js#default>
code:link <node:barnard59-sparql/construct.js#default>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a mistake before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guess so

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we'd also need to bump the version here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

packages/cube/package.json Outdated Show resolved Hide resolved
packages/cube/package.json Outdated Show resolved Hide resolved
packages/cube/package.json Outdated Show resolved Hide resolved
packages/cube/package.json Outdated Show resolved Hide resolved
(
_:queryConstraint
[ ntriples:serialize () ]
_:stdout
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need an explicit stdout step. That is the default behavior

Suggested change
_:stdout

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about this, I'll try again but I think I already tried and got no output

packages/cube/pipeline/cube-validation.ttl Outdated Show resolved Hide resolved
]
.

# relying on cbd is not ideal (vendor specific)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
We'll replace this with CONSTRUCT later

Comment on lines 173 to 180
_:batch a p:Step ;
code:implementedBy
[
a code:EcmaScriptModule ;
code:link <file:../lib/batch.js#batch> ;
] ;
code:arguments ("batchSize"^^p:VariableName)
.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there some step like this in barnard59-base?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently not, in fact I would consider adding one (or even two: one for datasets and another for generic objects)

packages/cube/pipeline/cube-validation.ttl Outdated Show resolved Hide resolved
Copy link
Contributor

@tpluscode tpluscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're good here 👍

@tpluscode tpluscode merged commit f45559f into master Nov 22, 2023
29 checks passed
@tpluscode tpluscode deleted the move-cube branch November 22, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants