-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wireviz version to latest #1779
Comments
We are using a fork: https://github.com/yuzutech/WireViz mainly because we are consuming wireviz as a binary CLI (and not as a Python library).
My pull request didn't get merged (wireviz/WireViz#321) but it seems that it's now possible to specify an output file. Not sure if outputting to stdout and reading the content from stdin are supported though... |
I've created Python wrapper for WireViz with no changes to existing WireViz files: Binary for Kroki can be downloaded here: You can merge this into https://github.com/yuzutech/WireViz/. This method should allow seamless upgrade of WireViz. I would create a pull request but I'm not familiar enough with CI scripts for your repo. Wrapper also supports WireViz version output with Here's a test output with local Kroki server and WireWiz v0.4 features (https://github.com/sgorsh/WireViz/blob/master/examples/ex12.yml): |
@sgorsh That's neat, thanks! Ideally, I would like to delete my fork and use the upstream version directly. Could you please open an issue on the upstream project to gradually implement this features upstream? Would it be possible to use the pip package instead of copying/forking the project? As far as I understand, all the custom code is inside `wireviz_kroki.py ? |
Kroki currently uses wireviz
v0.3.3
(which is not even an official version... see below). The latest version isv0.4.1
. Updating would be very nice.More detail...
The wireviz version currently in use is
v0.3.3
, per this line:kroki/server/ops/docker/jdk17-noble/Dockerfile
Line 180 in d96fd25
Curiously,
v0.3.3
is not even an official wireviz tag!? Officail Wireviz versions jump fromv0.3.2
tov0.4
, so I'm not sure howv0.3.3
works.The latest version of wireviz is
v0.4.1
, and it contains some significant, and long awaited, features.NOTE: You can't even run basic wireviz tutorials with the
v0.3.x
version included with Kroki! For example the syntax for this wireviz tutorial currently fails with the syntax below (also available at the kroki.io renderer here):The problem is the relatively new syntax in
connections:
withF1.
. Drop the.
and it renders... but not as it should.The text was updated successfully, but these errors were encountered: