Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Java version to 17 or 21 #1688

Open
heyLu opened this issue Jan 9, 2024 · 2 comments · Fixed by #1689
Open

Update Java version to 17 or 21 #1688

heyLu opened this issue Jan 9, 2024 · 2 comments · Fixed by #1689
Labels
🐋 docker Related to Docker code ☕ java Related to Java code 🔒 security Address a security vulnerability

Comments

@heyLu
Copy link
Contributor

heyLu commented Jan 9, 2024

Hi, would an update of kroki's Java version to 17 or 21 be welcome?

The company I work at uses kroki internally and has a policy for only allowing the last two LTS versions in production and would thus like to update to Java 17 or later.

If it's welcome, I'd open a PR to do the update.
@ggrossetie
Copy link
Member

Hey @heyLu

Yes, I'm willing to upgrade to Java 17. You can submit a PR 👍🏻

@ggrossetie ggrossetie added ☕ java Related to Java code 🐋 docker Related to Docker code 🔒 security Address a security vulnerability labels Jan 9, 2024
@heyLu heyLu mentioned this issue Jan 10, 2024
Merged
@ggrossetie ggrossetie reopened this Jan 17, 2024
@ggrossetie
Copy link
Member

We can keep it open until the minimum version is Java 17?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐋 docker Related to Docker code ☕ java Related to Java code 🔒 security Address a security vulnerability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Docker image to Java 17 heyLu/kroki
2 participants
@ggrossetie @heyLu