Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations very often not visible #16

Open
pun-ky opened this issue Mar 4, 2021 · 5 comments
Open

Annotations very often not visible #16

pun-ky opened this issue Mar 4, 2021 · 5 comments

Comments

@pun-ky
Copy link

pun-ky commented Mar 4, 2021

I am using also this annotations-action but on workflow_dispatch event. And even if the step finishes with a success, annotation is very often not visible / not attached to the "Jobs" area. Any ideas why?

@ggrossetie
Copy link
Member

ggrossetie commented Mar 5, 2021

@pun-ky Can you please share a link to a job where annotations are not attached and a job where annotation are attached?
PS: I removed your comment from #4 to avoid duplication.

@pun-ky
Copy link
Author

pun-ky commented Mar 5, 2021

It's on private github repo. Maybe this is a cause... Nothing special I've go there... What is also strange junit annotations step is also intermittently working ;/

@ggrossetie
Copy link
Member

It's on private github repo. Maybe this is a cause... Nothing special I've go there... What is also strange junit annotations step is also intermittently working ;/

I think it's mostly related to how the annotations API is designed.
I will try to run it using the workflow_dispatch event.
Maybe in this scenario, the check run has no commit attached and as a result we cannot attach annotations.

@pun-ky
Copy link
Author

pun-ky commented Mar 7, 2021

Hmm. That make sense because maybe only to first run annotations are attached. And next runs are not having them. Yep. That fits to what I've observed.

@potmo
Copy link

potmo commented Oct 6, 2023

I'm also seeing this on a private github repo that runs on PRs (annotating lint errors).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants