Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand fopen modes #457

Open
0x501D opened this issue Sep 29, 2023 · 0 comments · Fixed by tsukinoko-kun/gopher-lua#9 · May be fixed by #458
Open

Expand fopen modes #457

0x501D opened this issue Sep 29, 2023 · 0 comments · Fixed by tsukinoko-kun/gopher-lua#9 · May be fixed by #458

Comments

@0x501D
Copy link
Contributor

0x501D commented Sep 29, 2023

Flags: r+b, w+b, a+b are valid and works in C lua implementation.

Gopher-lua throws an error:
bad argument #2 to open (invalid option: r+b (must be one of r,rb,w,wb,a,ab,r+,rb+,w+,wb+,a+,ab+))
0x501D added a commit to 0x501D/gopher-lua that referenced this issue Sep 29, 2023
@0x501D
fopen: expand supported file modes
1c5b20e 
Support file modes: r+b, w+b, a+b.

Closes yuin#457
@0x501D 0x501D linked a pull request Sep 29, 2023 that will close this issue
Open
0x501D added a commit to 0x501D/gopher-lua that referenced this issue Dec 11, 2023
@0x501D
fopen: expand supported file modes
4cc745a 
Support file modes: r+b, w+b, a+b.

Closes yuin#457
0x501D added a commit to 0x501D/gopher-lua that referenced this issue Dec 12, 2023
@0x501D
fopen: expand supported file modes
2680c74 
Support file modes: r+b, w+b, a+b.

Closes yuin#457
0x501D added a commit to 0x501D/gopher-lua that referenced this issue Dec 12, 2023
@0x501D
fopen: expand supported file modes
5983e13 
Support file modes: r+b, w+b, a+b.

Closes yuin#457
@tsukinoko-kun tsukinoko-kun mentioned this issue Apr 2, 2024
Merged
tsukinoko-kun added a commit to tsukinoko-kun/gopher-lua that referenced this issue Apr 2, 2024
@tsukinoko-kun @0x501D
fopen: expand supported file modes (#9)
2c37dac 
Support file modes: r+b, w+b, a+b.

Closes yuin#457

Co-authored-by: Pavel Balaev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@0x501D