[ie/yandexvideo] Fix extractor #9813
Merged
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
pukkandan
approved these changes
May 1, 2024
It was more of the case that previous tests were not working than supporting something new/different but alright, will make a new test. |
|
No need. But are the existing tests passing now? |
Yes: (venv) [linux@linux yt-dlp]$ python3 devscripts/run_tests.py ZenYandex_all
Running ['pytest', '-Werror', '--tb=short', 'test/test_download.py::TestDownload::test_ZenYandex_all']
=========================================================================================================== test session starts ============================================================================================================
platform linux -- Python 3.11.8, pytest-8.2.0, pluggy-1.5.0 -- /home/linux/git/yt-dlp/venv/bin/python
cachedir: .pytest_cache
rootdir: /home/linux/git/yt-dlp
configfile: setup.cfg
collected 1 item
test/test_download.py::TestDownload::test_ZenYandex_all PASSED [100%]
============================================================================================================ 1 passed in 35.88s ============================================================================================================ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
The site has changed their JSON format, causing the failure of stream urls extraction. Basically this patch extracts stream urls from the new JSON format
Fixes #9803
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?