Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[security vulnerability] Arbitrary Address Update #114

Open
GatekeeperBuster opened this issue Dec 14, 2023 · 0 comments
Open

[security vulnerability] Arbitrary Address Update #114

GatekeeperBuster opened this issue Dec 14, 2023 · 0 comments

Comments

@GatekeeperBuster
Copy link

Recently, our team found a vulnerability causing the Arbitrary Address Update in the latest version of the project.

The vulnerability logic is present in the file: https://github.com/youlaitech/youlai-mall/blob/master/mall-ums/ums-boot/src/main/java/com/youlai/mall/ums/service/impl/UmsAddressServiceImpl.java#73.

屏幕截图 2023-12-14 123337

The developer failed to check the privilege of the accessor when updating status via com.baomidou.mybatisplus.extension.service.impl.ServiceImpl<OrderMapper,OmsOrder>.getById(), while the request of path /{addressId} is also unauthorized (i.e., https://github.com/youlaitech/youlai-mall/blob/master/mall-ums/ums-boot/src/main/java/com/youlai/mall/ums/controller/app/AddressController.java#L57), which means an attacker can achieve Arbitrary Address Update.
屏幕截图 2023-12-14 123621

To address this vulnerability, we strongly advise that developers implement access control policies that limit API access to admin users or the owner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant