Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Addon should warn about not initialised git submodule`s #25

Open
2 of 3 tasks
Lypsolon opened this issue Aug 22, 2024 · 0 comments
Open
2 of 3 tasks

Create Addon should warn about not initialised git submodule`s #25

Lypsolon opened this issue Aug 22, 2024 · 0 comments
Assignees
Labels
type: enhancement Improvement of existing functionality or minor addition

Comments

@Lypsolon
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues.

Please describe the feature you have in mind and explain what the current shortcomings are?

You can build the Addon and upload it to the server even if some submodules haven't been initialised.
This causes uploading a broken add-on and getting this info on the server to be too late.

How would you imagine the implementation of the feature?

Add a subprocess.run into the create a package file that runs ´git submodule update --init --recursive` for you to ensure all the submodules are initialised.

  • Check if this creates problems when you check out a branch or a different commit than the one set in the .gitmodules file.

Are there any labels you wish to add?

  • I have added the relevant labels to the enhancement request.

Describe alternatives you've considered:

No response

Additional context:

No response

@Lypsolon Lypsolon self-assigned this Aug 22, 2024
@Lypsolon Lypsolon added duplicate This issue or pull request already exists type: enhancement Improvement of existing functionality or minor addition and removed duplicate This issue or pull request already exists labels Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

No branches or pull requests

1 participant