-
Notifications
You must be signed in to change notification settings - Fork 428
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIP package #51
Comments
This repo serves as a research's project, but if it needed surely I can make a pip package. Do you need it for training or for inference? |
Mostly for inference. I was planning to make a Gradio demo, but I can also do that by just cloning the repo. (Might make a PR later if that's ok.) |
Yes, please do so if you can. Thanks for your contribution. |
This will require a restructuring of the files (putting them all in one folder) and may break the demos, so I'll work on it in a fork for now. |
I've got a very hacky fork that should be pip installable here (still need to create |
Thanks for this, and the demo, @fakerybakery Would be nice to have inference.py commited and mainlined. |
Hi @lxe, by I'm going to delete my pip fork because it breaks training, config, etc. Personally, I think it would be better to have an external "wrapper" repository that's pip-installable to keep the training scripts, similar to how VoiceFixer has the VoiceFixer pip installable package and the VoiceFixer main repository with training scripts, etc. |
@yl4579 would you mind adding this to the "todo" list in the README? |
My main concern of this is it could contain phonemizer and change the license of the repo. I use notebook intentionally so it doesn't contain any non-MIT libraries. Even if I add it to TODO it probably wouldn't be a part of this repo anyway. |
OK, please see the other comment about the fork |
I was able to wrangle around the inability to import this in my own package: https://github.com/lxe/tts-server Here's what I needed to do:
I think a lot of this styletts code needs some relative module imports and some other cleanup |
I think I can move this to discussion now, as making a pip package would inevitably ruin the current MIT license status unless we have a good MIT licensed phonemizer alternative. |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
Hi, are you planning to allow us to install this via pip by creating a
setup.py
file?The text was updated successfully, but these errors were encountered: