Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Loops to a separate package? #55

Open
viktorprogger opened this issue Jul 31, 2020 · 8 comments
Open

Move Loops to a separate package? #55

viktorprogger opened this issue Jul 31, 2020 · 8 comments

Comments

@viktorprogger
Copy link
Contributor

It will give us ability to use signal loop from any console application, and even from RoadRunner.

@viktorprogger
Copy link
Contributor Author

@yiisoft/yii3, your opinions?

@samdark
Copy link
Member

samdark commented Aug 3, 2020

Do you mean signal handling etc.?

@viktorprogger
Copy link
Contributor Author

viktorprogger commented Aug 4, 2020

@samdark, yes. We'll also be able to use it inside new version of yii-console.

@samdark
Copy link
Member

samdark commented Aug 4, 2020

I'm fine about that but not sure about package name. Also it may make sense to make it part of the console package itself.

@viktorprogger
Copy link
Contributor Author

As a result of some research I suggest to move it to yii-console too. To move class, make it final and delete its interface.

@viktorprogger viktorprogger added status:ready for adoption Feel free to implement this issue. and removed status:under discussion labels Aug 4, 2020
@viktorprogger
Copy link
Contributor Author

viktorprogger commented Sep 14, 2020

Need to be implemented after yiisoft/yii-console#46

@viktorprogger viktorprogger added the good first issue Simple enough issue to start with. label Feb 14, 2022
@viktorprogger viktorprogger added status:under discussion and removed good first issue Simple enough issue to start with. status:ready for adoption Feel free to implement this issue. labels Nov 10, 2022
@viktorprogger
Copy link
Contributor Author

We need to discuss this decision again, I think.

@samdark
Copy link
Member

samdark commented Nov 10, 2022

Could be postponed after release, I think, because loops are internal thing to queue and would unlikely be used separately before we extract them.

@viktorprogger viktorprogger removed this from the 1.0.0-alpha1 milestone Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants