{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":84136061,"defaultBranch":"main","name":"folly","ownerLogin":"yfeldblum","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2017-03-07T00:41:58.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/169419?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1718992601.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"090eb521c958650cd24de4834ef7bca1edab9f48","ref":"refs/heads/export-D58870593","pushedAt":"2024-06-21T17:56:41.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"yfeldblum","name":"Jay Feldblum","path":"/yfeldblum","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/169419?s=80&v=4"},"commit":{"message":"fix exception-access build under FreeBSD <= 14.0\n\nSummary:\nFreeBSD 14.1 introduced the function definition `__cxa_init_primary_exception` and introduced into `cxxabi.h` the function declarations `__cxa_allocate_exception` and `__cxa_free_exception`. Assuming them breaks the build under FreeBSD <= 14.0.\n\nFor now under all FreeBSD, just declare `__cxa_allocate_exception` and `__cxa_free_exception` and do not use `__cxa_init_primary_exception`.\n\nFixes: https://github.com/facebook/folly/issues/2240.\n\nDifferential Revision: D58870593","shortMessageHtmlLink":"fix exception-access build under FreeBSD &lt;= 14.0"}},{"before":null,"after":"4d83a608d542f9fe6d14599c1ca33517503899f8","ref":"refs/heads/export-D58626578","pushedAt":"2024-06-15T00:47:23.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"yfeldblum","name":"Jay Feldblum","path":"/yfeldblum","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/169419?s=80&v=4"},"commit":{"message":"add missing exceptions helper under FreeBSD\n\nSummary:\nFreeBSD uses libc++ with libcxxrt, as v.s. libc++ with libc++'s cxxabi. The folly wrappers used a helper `cxxabi_with_cxa_exception` that we define only for libc++ with libc++'s cxxabi, so define it also for libc++ with libcxxrt under FreeBSD.\n\nThe breakage blames to {D57677424}, which introduced the call under libc++ unconditionally.\n\nFixes: https://github.com/facebook/folly/issues/2232.\n\nDifferential Revision: D58626578","shortMessageHtmlLink":"add missing exceptions helper under FreeBSD"}},{"before":null,"after":"a98e5ff826dfb3afdc9b5a839659a60ca2361947","ref":"refs/heads/export-D57172836","pushedAt":"2024-05-10T14:11:12.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"yfeldblum","name":"Jay Feldblum","path":"/yfeldblum","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/169419?s=80&v=4"},"commit":{"message":"packing in the PicoSpinLock test does not seem to work under MSCV\n\nSummary:\nThis breaks some builds. So skip the static-assert which checks that it works.\n\nMinimal repro: https://godbolt.org/z/bdEn648Gr. Seems that MSCV doesn't imbue packing into fields that explicitly have their own alignments while GCC does.\n\nReviewed By: DenisYaroshevskiy\n\nDifferential Revision: D57172836","shortMessageHtmlLink":"packing in the PicoSpinLock test does not seem to work under MSCV"}},{"before":null,"after":"54e97af7e6c37f1169e108f09f73d2467c5cd82f","ref":"refs/heads/export-D57167715","pushedAt":"2024-05-09T18:05:06.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"yfeldblum","name":"Jay Feldblum","path":"/yfeldblum","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/169419?s=80&v=4"},"commit":{"message":"fix path conversion to c-str in SSLSessionTest\n\nSummary: On Windows, `boost::filesystem::path::c_str()` has type `wchar_t const*` and not `char const*`; passing the result to `SSLContext` members does not compile.\n\nReviewed By: vitaut\n\nDifferential Revision: D57167715","shortMessageHtmlLink":"fix path conversion to c-str in SSLSessionTest"}},{"before":null,"after":"5ea67810bdfcdee9bf3ae62230d3d84af7b5a696","ref":"refs/heads/export-D57017204","pushedAt":"2024-05-07T14:40:44.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"yfeldblum","name":"Jay Feldblum","path":"/yfeldblum","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/169419?s=80&v=4"},"commit":{"message":"bump repo ci to ubuntu-22.04\n\nSummary:\nX-link: https://github.com/facebookincubator/zstrong/pull/782\n\nNow that Ubuntu 24.04 LTS [has been released](https://ubuntu.com/blog/canonical-releases-ubuntu-24-04-noble-numbat), it is a suitable time to bump the version of Ubuntu used in CI to Ubuntu 22.04 LTS, which is the prior LTS.\n\nUbuntu 22.04 LTS ships with GCC 11.2, and is the first Ubuntu release to ship with a version of GCC that implements C++20 coroutines.\n\nReviewed By: chadaustin\n\nDifferential Revision: D57017204","shortMessageHtmlLink":"bump repo ci to ubuntu-22.04"}},{"before":null,"after":"c7319b9efdf5af9873daab7a572ad78e34c35684","ref":"refs/heads/export-D56953408","pushedAt":"2024-05-03T21:38:43.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"yfeldblum","name":"Jay Feldblum","path":"/yfeldblum","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/169419?s=80&v=4"},"commit":{"message":"tweak test-certs bits\n\nSummary: Tweaks have to do with internal logic to find resource files.\n\nDifferential Revision: D56953408","shortMessageHtmlLink":"tweak test-certs bits"}},{"before":"45123421849a5414dcb62a852d4bc33738cfc050","after":"c5a7890ca4e717a03cd0352594af90b1e47e893a","ref":"refs/heads/export-D42509278","pushedAt":"2024-03-25T15:58:04.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"yfeldblum","name":"Jay Feldblum","path":"/yfeldblum","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/169419?s=80&v=4"},"commit":{"message":"Add LibUnwind as a dependency of glog::glog (#1916)\n\nSummary:\n\n\nX-link: https://github.com/facebook/hhvm/pull/9179\n\nX-link: https://github.com/facebook/fboss/pull/119\n\nX-link: https://github.com/facebook/fb303/pull/32\n\nX-link: https://github.com/facebook/openr/pull/141\n\nX-link: https://github.com/facebook/fbthrift/pull/524\n\nX-link: https://github.com/facebook/wangle/pull/209\n\nX-link: https://github.com/facebook/proxygen/pull/429\n\nX-link: https://github.com/facebookexperimental/eden/pull/128\n\nX-link: https://github.com/facebookexperimental/rust-shed/pull/35\n\nX-link: https://github.com/facebook/watchman/pull/1058\n\nX-link: https://github.com/facebookincubator/reindeer/pull/5\n\nX-link: https://github.com/facebook/sapling-staging/pull/8\n\nX-link: https://github.com/facebookexperimental/edencommon/pull/5\n\nX-link: https://github.com/facebookincubator/fizz/pull/82\n\nX-link: https://github.com/facebookincubator/velox/pull/2487\n\nX-link: https://github.com/facebookincubator/hsthrift/pull/101\n\nX-link: https://github.com/facebookincubator/katran/pull/172\n\nX-link: https://github.com/facebookincubator/mvfst/pull/273\n\nX-link: https://github.com/fairinternal/AIRStore/pull/38\n\n`LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property.\n\nWithout this diff, there will be a linker error like this:\n```\n/usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext'\n//usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line\ncollect2: error: ld returned 1 exit status\n```\n\nReviewed By: Wilfred\n\nDifferential Revision: D42509278","shortMessageHtmlLink":"Add LibUnwind as a dependency of glog::glog (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1532974889\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/folly/issues/1916\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/folly/pull/1916/hovercard\" href=\"https://github.com/facebook/folly/pull/1916\">facebook#1916</a>)"}},{"before":"cc80f0f83dc1033d6a085d3d69643874bdcf07b9","after":"1b0727a2eb8321de3161cfbe17812a8770e717c9","ref":"refs/heads/export-D48440179","pushedAt":"2023-08-18T17:19:20.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"yfeldblum","name":"Jay Feldblum","path":"/yfeldblum","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/169419?s=80&v=4"},"commit":{"message":"work around gcc build failure (#2054)\n\nSummary:\nPull Request resolved: https://github.com/facebook/folly/pull/2054\n\nOne line in a unit-test exercising the class template argument deduction guides for the F14FastMap etc containers fails to compile under gcc, until at least gcc v12. The line should compile, and does compile under clang.\n\nTo work around, we exclude this line when building under gcc.\n\nReviewed By: Orvid\n\nDifferential Revision: D48440179\n\nfbshipit-source-id: 2b0d6b8cb2d330b3c2572a661766f238629eee31","shortMessageHtmlLink":"work around gcc build failure (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1855515687\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/folly/issues/2054\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/folly/pull/2054/hovercard\" href=\"https://github.com/facebook/folly/pull/2054\">facebook#2054</a>)"}},{"before":null,"after":"cc80f0f83dc1033d6a085d3d69643874bdcf07b9","ref":"refs/heads/export-D48440179","pushedAt":"2023-08-17T18:36:34.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"yfeldblum","name":"Jay Feldblum","path":"/yfeldblum","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/169419?s=80&v=4"},"commit":{"message":"work around gcc build failure\n\nSummary:\nOne line in a unit-test exercising the class template argument deduction guides for the F14FastMap etc containers fails to compile under gcc, until at least gcc v12. The line should compile, and does compile under clang.\n\nTo work around, we exclude this line when building under gcc.\n\nReviewed By: Orvid\n\nDifferential Revision: D48440179\n\nfbshipit-source-id: f1d6a3870e8189766dd9d205c031de52ca3a7f0f","shortMessageHtmlLink":"work around gcc build failure"}},{"before":"f52c625f22a4f461e251dfb3bed41c5921bdfcbc","after":"45123421849a5414dcb62a852d4bc33738cfc050","ref":"refs/heads/export-D42509278","pushedAt":"2023-05-22T17:04:19.005Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"yfeldblum","name":"Jay Feldblum","path":"/yfeldblum","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/169419?s=80&v=4"},"commit":{"message":"Add LibUnwind as a dependency of glog::glog (#1916)\n\nSummary:\nPull Request resolved: https://github.com/facebook/folly/pull/1916\n\nPull Request resolved: https://github.com/facebook/folly/pull/1857\n\nX-link: https://github.com/facebook/hhvm/pull/9179\n\nX-link: https://github.com/facebook/fboss/pull/119\n\nX-link: https://github.com/facebook/fb303/pull/32\n\nX-link: https://github.com/facebook/openr/pull/141\n\nX-link: https://github.com/facebook/fbthrift/pull/524\n\nX-link: https://github.com/facebook/wangle/pull/209\n\nX-link: https://github.com/facebook/proxygen/pull/429\n\nX-link: https://github.com/facebookexperimental/eden/pull/128\n\nX-link: https://github.com/facebookexperimental/rust-shed/pull/35\n\nX-link: https://github.com/facebook/watchman/pull/1058\n\nX-link: https://github.com/facebookincubator/reindeer/pull/5\n\nX-link: https://github.com/facebook/sapling-staging/pull/8\n\nX-link: https://github.com/facebookexperimental/edencommon/pull/5\n\nX-link: https://github.com/facebookincubator/fizz/pull/82\n\nX-link: https://github.com/facebookincubator/velox/pull/2487\n\nX-link: https://github.com/facebookincubator/hsthrift/pull/101\n\nX-link: https://github.com/facebookincubator/katran/pull/172\n\nX-link: https://github.com/facebookincubator/mvfst/pull/273\n\nX-link: https://github.com/fairinternal/AIRStore/pull/38\n\n`LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property.\n\nWithout this diff, there will be a linker error like this:\n```\n/usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext'\n//usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line\ncollect2: error: ld returned 1 exit status\n```\n\nReviewed By: Wilfred\n\nDifferential Revision: D42509278\n\nfbshipit-source-id: 47db28bacea510e8b8f8e556c1ae86dce29e6d91","shortMessageHtmlLink":"Add LibUnwind as a dependency of glog::glog (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1532974889\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/folly/issues/1916\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/folly/pull/1916/hovercard\" href=\"https://github.com/facebook/folly/pull/1916\">facebook#1916</a>)"}},{"before":"13dd05c5444dc58c2d41a7653919da6415182271","after":"f52c625f22a4f461e251dfb3bed41c5921bdfcbc","ref":"refs/heads/export-D42509278","pushedAt":"2023-05-17T17:11:14.668Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"yfeldblum","name":"Jay Feldblum","path":"/yfeldblum","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/169419?s=80&v=4"},"commit":{"message":"Add LibUnwind as a dependency of glog::glog (#1916)\n\nSummary:\nPull Request resolved: https://github.com/facebook/folly/pull/1916\n\nPull Request resolved: https://github.com/facebook/folly/pull/1857\n\nX-link: https://github.com/facebook/hhvm/pull/9179\n\nX-link: https://github.com/facebook/fboss/pull/119\n\nX-link: https://github.com/facebook/fb303/pull/32\n\nX-link: https://github.com/facebook/openr/pull/141\n\nX-link: https://github.com/facebook/fbthrift/pull/524\n\nX-link: https://github.com/facebook/wangle/pull/209\n\nX-link: https://github.com/facebook/proxygen/pull/429\n\nX-link: https://github.com/facebookexperimental/eden/pull/128\n\nX-link: https://github.com/facebookexperimental/rust-shed/pull/35\n\nX-link: https://github.com/facebook/watchman/pull/1058\n\nX-link: https://github.com/facebookincubator/reindeer/pull/5\n\nX-link: https://github.com/facebook/sapling-staging/pull/8\n\nX-link: https://github.com/facebookexperimental/edencommon/pull/5\n\nX-link: https://github.com/facebookincubator/fizz/pull/82\n\nX-link: https://github.com/facebookincubator/velox/pull/2487\n\nX-link: https://github.com/facebookincubator/hsthrift/pull/101\n\nX-link: https://github.com/facebookincubator/katran/pull/172\n\nX-link: https://github.com/facebookincubator/mvfst/pull/273\n\nX-link: https://github.com/fairinternal/AIRStore/pull/38\n\n`LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property.\n\nWithout this diff, there will be a linker error like this:\n```\n/usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext'\n//usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line\ncollect2: error: ld returned 1 exit status\n```\n\nReviewed By: Wilfred\n\nDifferential Revision: D42509278\n\nfbshipit-source-id: 79aa2e3d06b0d4f3b60ab4e9f46e51de214e8041","shortMessageHtmlLink":"Add LibUnwind as a dependency of glog::glog (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1532974889\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/folly/issues/1916\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/folly/pull/1916/hovercard\" href=\"https://github.com/facebook/folly/pull/1916\">facebook#1916</a>)"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNi0yMVQxNzo1Njo0MS4wMDAwMDBazwAAAARr2GqC","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNi0yMVQxNzo1Njo0MS4wMDAwMDBazwAAAARr2GqC","endCursor":"Y3Vyc29yOnYyOpK7MjAyMy0wNS0xN1QxNzoxMToxNC42NjgzMjhazwAAAAMu0Jax"}},"title":"Activity · yfeldblum/folly"}