Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow drag selection inside nodes #4280

Open
hiepnguyen3001 opened this issue May 16, 2024 · 11 comments
Open

Allow drag selection inside nodes #4280

hiepnguyen3001 opened this issue May 16, 2024 · 11 comments
Assignees
Labels
feature request New feature or request

Comments

@hiepnguyen3001
Copy link

Please describe the feature that you want to propose

Currently, it is not possible to start a drag selection box inside a node. May I suggest a new property like enableDragSelect?

I'm aware this behavior means that you cannot drag the node itself anymore. But in that case, we can make it so that drag selection is only enabled inside node when it has a specified dragHandle. Then both dragging node by its drag handle and drag selection inside node is possible.

@hiepnguyen3001 hiepnguyen3001 added the feature request New feature or request label May 16, 2024
@bcakmakoglu
Copy link
Contributor

You might wanna read this section of the docs.

TL;DR: add the nodrag class name to elements that should not initiate a drag action inside a node.

@hiepnguyen3001
Copy link
Author

But that only prevents dragging the node, and you still cannot start drag selection from inside the node.

@bcakmakoglu
Copy link
Contributor

Well, add some css to the element user-select: text; or all and you're good.

@hiepnguyen3001
Copy link
Author

hiepnguyen3001 commented May 17, 2024

I did and it still doesn't work.

Screen.Recording.2024-05-17.at.13.21.17.mov

@bcakmakoglu
Copy link
Contributor

Mh... not quite sure what the video is supposed to tell me? What exactly are you trying to achieve with "dragging" here?

@hiepnguyen3001
Copy link
Author

In the video I start dragging outside of the box it triggers drag selection but when I do it from inside the box nothing happens.

@bcakmakoglu
Copy link
Contributor

Aha! Well that's quite different from the original issue I assumed you had (thought you were trying to use some input text selection or whatever inside of a node, which the above class name + css would've allowed).
So the problem is using the RF built-in selection box while having the mouse on a node, is that correct?

@bcakmakoglu
Copy link
Contributor

If that's the case, I don't think that works out of the box sadly - so your initial request might make sense although that's for the maintainers to decide and not me 😄

At least we were able to clarify what the exact issue here is ^^

@moklick
Copy link
Member

moklick commented Jun 2, 2024

That's a good question @hiepnguyen3001. Unfortunately this is only possible with a workaround. You could listen to the selection key and set nodesDraggable={false} for example. Would that work?

@moklick moklick self-assigned this Jun 2, 2024
@hiepnguyen3001
Copy link
Author

That's a good question @hiepnguyen3001. Unfortunately this is only possible with a workaround. You could listen to the selection key and set nodesDraggable={false} for example. Would that work?

I don't think so @moklick. Even when I set nodesDraggable={false}, it's still not possible to start a selection box from inside a node.

@moklick
Copy link
Member

moklick commented Jun 3, 2024

Damn.. The only way I see then is to add a class or set a style directly that prevents all pointer events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants