Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XxlJobAdminConfig bug? #3454

Open
john1337 opened this issue May 16, 2024 · 2 comments
Open

XxlJobAdminConfig bug? #3454

john1337 opened this issue May 16, 2024 · 2 comments

Comments

@john1337
Copy link

public int getLogretentiondays() {
    if (logretentiondays < 7) {
        return -1;  // Limit greater than or equal to 7, otherwise close
    }
    return logretentiondays;
}

该方法注释与实际意图明显不一致,代码显示的是logretentiondays 配置若小于7则不清理日志,这有问题吧,比如就是要保存日志短一点,比如保留3天,上面的代码将导致日志清理任务永远不执行
image

@zhipingwu
Copy link

注释需要改改,改为make sure greater than 7 days, otherwise keep all log

@zhipingwu zhipingwu mentioned this issue May 31, 2024
6 tasks
@john1337
Copy link
Author

john1337 commented Jun 6, 2024

注释需要改改,改为make sure greater than 7 days, otherwise keep all log

那可能应用场景不一样,日志表很大时启停任务接口耗时就会增加到1秒以上,所以我自己的应用场景是更短的清除周期

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants